← Back
androidx/androidx

[Core] Add ftp to PatternsCompat PROTOCOL to match platform Patterns

androidx/androidx · #905

Aug 2026

Proposed Changes Add ftp to PatternsCompat.PROTOCOL, matching android.util.Patterns, which added it in Android 12. This affects PatternsCompat.WEB_URL and PatternsCompat.AUTOLINK_WEB_URL, both of which currently fail to match ftp:// URLs that the platform matches on API 31+. PatternsCompatTest used ftp:// as its example of an invalid protocol in three places. Those are retargeted to gopher://, wh…

open
status
+18/−4
diff
6.1K
repo stars
View the pull request

More like this

flutter/flutter

Fix self-comparison and assert typos in TestSemantics

flutter/flutter · #191938

This replaces #185975, which the stale bot auto-closed on Jul 1. The requested tests had been pushed on May 21 (commit "Add semantics tester regression tests"), but the waiting for response label was never cleared, so the timer kept running. #185975 could not be reopened, hence this PR. @chunhtai you'd reviewed #185975 and said it lgtm pending a test. That test is here — three regression tests, o…

open
status
+134/−4
diff
179K
repo stars
flutter/flutter

Remove semantics_tester import from material_button_test.dart

flutter/flutter · #184807

Part of #182636 Summary Remove the semantics_tester.dart cross-import from material_button_test.dart. What changed Replaced the deprecated SemanticsTester/TestSemantics assertions in the MaterialButton semantics test with tester.getSemantics(...) and matchesSemantics(...) Kept the semantic size verification for the enabled and disabled button states Removed the ../widgets/semantics_tester.dart im…

merged
status
+32/−50
diff
179K
repo stars
flutter/flutter

Remove semantics_tester import from cupertino/slider_test.dart

flutter/flutter · #184805

Part of #182636 Summary Remove the semantics_tester.dart cross-import from cupertino/slider_test.dart. What changed Replaced the deprecated SemanticsTester/TestSemantics assertion in the slider semantics test with tester.getSemantics(...) and matchesSemantics(...) Removed the ../widgets/semantics_tester.dart import Testing ../../bin/flutter analyze test/cupertino/slider_test.dart ../../bin/flutte…

merged
status
+12/−33
diff
179K
repo stars