Remove sliver_test_utils cross-import from sliver_app_bar_test

Include Wrap spacing in max intrinsic main-axis extent

flutter/flutter · #192613

Include spacing in RenderWrap.computeMaxIntrinsicWidth (horizontal) and computeMaxIntrinsicHeight (vertical). IntrinsicWidth / IntrinsicHeight consumers (including PopupMenu) were under-sizing children that use Wrap(spacing: ...), because max intrinsic main-axis extent ignored inter-child spacing. Fixes Pre-launch Checklist I read the [Contributor Guide] and followed the process outlined there fo…

open

status

+45/−0

diff

180K

repo stars

Apply TestSemantics fixes to the material copy of semantics_tester

flutter/flutter · #192164

packages/flutter/test/material/semantics_tester.dart is a copy of packages/flutter/test/widgets/semantics_tester.dart, kept so material tests do not cross-import from widgets. It did not receive the fixes from #191938, so the two copies had drifted by exactly those four bugs: controlsNodes != controlsNodes compares the field to itself, so the setEquals check is unreachable and the expectation nev…

closed

status

+129/−4

diff

180K

repo stars

Fix self-comparison and assert typos in TestSemantics

flutter/flutter · #191938

This replaces #185975, which the stale bot auto-closed on Jul 1. The requested tests had been pushed on May 21 (commit "Add semantics tester regression tests"), but the waiting for response label was never cleared, so the timer kept running. #185975 could not be reopened, hence this PR. @chunhtai you'd reviewed #185975 and said it lgtm pending a test. That test is here — three regression tests, o…

merged

status

+134/−4

diff

180K

repo stars